Re: Re: [PATCH v2] iio: light: stk3310: Deal with the ps interrupt issue in PM
From: Miao Li
Date: Wed Apr 29 2026 - 03:56:06 EST
> > struct mutex lock;
> > bool als_enabled;
> > bool ps_enabled;
> > + bool ps_int_enabled;
> > + uint32_t ps_thdl;
> > + uint32_t ps_thdh;
>
> I still think we shouldn't add more {u}intXX_t into the drivers.
> Just add a patch on top of this to clean up those types to use
> kernel regular ones (uXX/sXX) instead.
>
> > uint32_t ps_near_level;
> > u64 timestamp;
> > struct regmap *regmap;
>
> I also haven't seen the response on `pahole` run. Is that tool happy with
> the proposed layout?
Hi, Andy
Patch v3 only fixes a few syntax errors in the function resume()
that were introduced by patch v2,
what you said I will revise at patch v4.
Best Regards.