Re: [PATCH v3] arm64: dts: qcom: sm8750: Add camera clock controller

[Taniya Das]

On 2/25/2026 7:48 PM, Konrad Dybcio wrote:
> On 2/25/26 11:12 AM, Taniya Das wrote:
>> The camera clock controller is split into cambistmclk and camcc. The
>> cambist clock controller handles the mclks and the rest of the clocks of
>> camera are part of the camcc clock controller.
>> Add the camcc clock controller device node for SM8750 SoC.
>>
>> Reviewed-by: Abel Vesa <abel.vesa@xxxxxxxxxxxxxxxx>
>> Signed-off-by: Taniya Das <taniya.das@xxxxxxxxxxxxxxxx>
>> ---
> 
> [...]
> 
>> +		cambistmclkcc: clock-controller@1760000 {
>> +		       compatible = "qcom,sm8750-cambistmclkcc";
>> +		       reg = <0x0 0x1760000 0x0 0x6000>;
>> +		       clocks = <&gcc GCC_CAM_BIST_MCLK_AHB_CLK> ,
> 
> Stray space before the comma

Yes, will fix this in the next patch.

> 
>> +				<&bi_tcxo_div2>,
>> +				<&bi_tcxo_ao_div2>,
>> +				<&sleep_clk>;
>> +			power-domains = <&rpmhpd RPMHPD_MMCX>,
> 
> I find it difficult to believe, but the computer tells me CAM_BIST_MCLK_CC
> is powered from *CX*, notably *not MMCX*, could you please double-check that
> as well?
> 

Sorry for the long delay in response Konrad. Most of the CAM_BIST_MCLK
are on MxA, only few debug clocks are in the "CX" domain. But the
CAM_BIST_PLL0 fails to lock without MMCX enable. That is the reason to
keep the power-domain to MMCX.

-- 
Thanks,
Taniya Das