Re: [PATCH v2] EDAC: i7300: disable error reporting if init fails and refactor helper

[Tushar Tibude]

> > From: Tushar Tibude <tushar.tibude1000@xxxxxxxxx>
> > [...]
> > @@ -1147,6 +1154,8 @@ static void i7300_remove_one(struct pci_dev
> > *pdev)
> >
> >       tmp = ((struct i7300_pvt *)mci->pvt_info)->tmp_prt_buffer;
> >
> > +     /* Disable error reporting before unregistering device */
> > +     i7300_set_error_reporting(mci, false);
>
> Do we need to disable error reporting conditionally when unloading the driver?
>
>         if (enabled_error_reporting)
>                 i7300_set_error_reporting(mci, false);
>
> >       /* retrieve references to resources, and free those resources */
> >       i7300_put_devices(mci);
> >
> > --
> > 2.43.0
>

Thank you for pointing that out, I've sent v3 keeping this in mind.