Re: [PATCH] arm64: dts: qcom: slim7x: Add Embedded Controller node

[Konrad Dybcio]

On 4/29/26 12:32 PM, Daniel J Blueman wrote:
> The Lenovo Slim7x uses the same Embedded Controller as the Qualcomm
> Hamoa Customer Reference Device (X1). Wire it up for fan control,
> thermal sensor and suspend behaviour.
> 
> Dependencies:
> https://lore.kernel.org/all/20260427-add-driver-for-ec-v8-0-702f74e495f7@xxxxxxxxxxxxxxxx/

This should not be part of the commit message - please put it under
the --- line, so git doesn't keep it in history
> 
> Signed-off-by: Daniel J Blueman <daniel@xxxxxxxxx>
> ---
>  .../dts/qcom/x1e80100-lenovo-yoga-slim7x.dts  | 22 +++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
> index beb1475d7fa0..22c4ad34a2a4 100644
> --- a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
> +++ b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
> @@ -951,6 +951,22 @@ retimer_ss0_con_sbu_out: endpoint {
>  	};
>  };
>  
> +&i2c5 {
> +	clock-frequency = <400000>;
> +
> +	status = "okay";
> +
> +	embedded-controller@76 {
> +		compatible = "qcom,glymur-crd-ec", "qcom,hamoa-crd-ec";

This should have its own compatible. The Glymur CRD is a different
laptop, with a different SoC. That will need a change to

Documentation/devicetree/bindings/embedded-controller/qcom,hamoa-crd-ec.yaml

so that dt validation passes

Konrad