RE: [PATCH v3] EDAC: i7300: disable error reporting if init fails and refactor helper

[Zhuo, Qiuxu]

> From: Tushar Tibude <tushar.tibude1000@xxxxxxxxx>
> Sent: Wednesday, April 29, 2026 5:48 PM
> To: mchehab@xxxxxxxxxx; bp@xxxxxxxxx; Luck, Tony <tony.luck@xxxxxxxxx>;
> linux-edac@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Cc: Zhuo, Qiuxu <qiuxu.zhuo@xxxxxxxxx>; Tushar Tibude
> <tushar.tibude1000@xxxxxxxxx>
> Subject: [PATCH v3] EDAC: i7300: disable error reporting if init fails and
> refactor helper
> 
> If error reporting is enabled during initialization but initialization fails
> immediately after, or during normal driver exit, error reporting is left enabled
> in the mask register even after exit.
> 
> Replace i7300_enable_error_reporting() with i7300_set_error_reporting() to
> combine enabling/disabling. Disable reporting at initialization failure and
> driver exit, before call to i7300_put_devices() for cleanup.
> Add enabled reporting flag to i7300_pvt.
> 
> This ensures clean hardware handling by disabling any unused error reporting
> bits before exiting.
> 
> Signed-off-by: Tushar Tibude <tushar.tibude1000@xxxxxxxxx>
> ---
> v2:
>  - Replace disable function with i7300_set_error_reporting
>  - Disable reporting at normal driver exit
>  - Move enabled_error_reporting flag initialization
> v3:
>  - Move enabled_error_reporting flag to i7300_pvt struct
>  - Conditionally disable error reporting at normal driver exit
> drivers/edac/i7300_edac.c | 33 ++++++++++++++++++++++++---------
>  1 file changed, 24 insertions(+), 9 deletions(-)

LGTM. Thanks.

  Reviewed-by: Qiuxu Zhuo <qiuxu.zhuo@xxxxxxxxx>