Re: [PATCH 1/2] firmware: qcom_scm: Fix qcom_scm_pas_prepare_and_auth_reset() kerneldoc

[Mukesh Ojha]

On Wed, Apr 29, 2026 at 07:52:07PM +0800, Shawn Guo wrote:
> The PAS context helper function added by commit ccb7bde5f7cc ("firmware:
> qcom_scm: Introduce PAS context allocator helper function") is
> devm_qcom_scm_pas_context_alloc() rather than qcom_scm_pas_context_init().
> 
> Fixes: 4a7d6a78fbc6 ("firmware: qcom_scm: Add a prep version of auth_and_reset function")
> Signed-off-by: Shawn Guo <shengchao.guo@xxxxxxxxxxxxxxxx>
> ---
>  drivers/firmware/qcom/qcom_scm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_scm.c
> index 9b06a69d3a6d..3b762059616a 100644
> --- a/drivers/firmware/qcom/qcom_scm.c
> +++ b/drivers/firmware/qcom/qcom_scm.c
> @@ -986,7 +986,7 @@ EXPORT_SYMBOL_GPL(qcom_scm_pas_auth_and_reset);
>   * qcom_scm_pas_prepare_and_auth_reset() - Prepare, authenticate, and reset the
>   *					   remote processor
>   *
> - * @ctx:	Context saved during call to qcom_scm_pas_context_init()
> + * @ctx:	Context saved during call to devm_qcom_scm_pas_context_alloc()
>   *
>   * This function performs the necessary steps to prepare a PAS subsystem,
>   * authenticate it using the provided metadata, and initiate a reset sequence.

Reviewed-by: Mukesh Ojha <mukesh.ojha@xxxxxxxxxxxxxxxx>

> -- 
> 2.43.0
> 

-- 
-Mukesh Ojha