Re: [PATCH 2/2] soc: qcom: mdt_loader: Fix qcom_mdt_pas_load() kerneldoc

[Mukesh Ojha]

On Wed, Apr 29, 2026 at 07:52:08PM +0800, Shawn Guo wrote:
> The PAS context helper function added by commit ccb7bde5f7cc ("firmware:
> qcom_scm: Introduce PAS context allocator helper function") is
> devm_qcom_scm_pas_context_alloc() rather than qcom_scm_pas_context_init().
> 
> Fixes: 8a4fcffde6c8 ("soc: qcom: mdtloader: Add PAS context aware qcom_mdt_pas_load() function")
> Signed-off-by: Shawn Guo <shengchao.guo@xxxxxxxxxxxxxxxx>
> ---
>  drivers/soc/qcom/mdt_loader.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/qcom/mdt_loader.c b/drivers/soc/qcom/mdt_loader.c
> index c004d444d698..75c1d472d930 100644
> --- a/drivers/soc/qcom/mdt_loader.c
> +++ b/drivers/soc/qcom/mdt_loader.c
> @@ -472,7 +472,7 @@ EXPORT_SYMBOL_GPL(qcom_mdt_load);
>   * firmware segments (e.g., .bXX files). Authentication of the segments done
>   * by a separate call.
>   *
> - * The PAS context must be initialized using qcom_scm_pas_context_init()
> + * The PAS context must be initialized using devm_qcom_scm_pas_context_alloc()

FYI, it should be again rename to devm_qcom_pas_context_alloc()
https://lore.kernel.org/lkml/20260427095603.1157963-3-sumit.garg@xxxxxxxxxx/

In case this lands earlier..


Reviewed-by: Mukesh Ojha <mukesh.ojha@xxxxxxxxxxxxxxxx>

>   * prior to invoking this function.
>   *
>   * @ctx:        Pointer to the PAS (Peripheral Authentication Service) context
> -- 
> 2.43.0
> 

-- 
-Mukesh Ojha