Re: [Intel-wired-lan] [PATCH] i40e: Fix i40e_debug() to use struct i40e_hw argument

[Mohamed Khalfella]

On Wed 2026-04-29 13:02:00 +0200, Paul Menzel wrote:
> Dear Mohamed,
> 
> 
> Thank you for your patch.
> 
> Am 28.04.26 um 20:14 schrieb Mohamed Khalfella:
> > i40e_debug() macro takes struct i40e_hw *h as first argument. But the
> > macro body uses hw instead of h. This has been working so far because hw
> > happen to be the name of the variable in the context where the marco is
> 
> marco → ma*cr*o

Good catch. Also 'happen' should be 'happens'

> 
> > expanded. Fix the macro to use the passed argument.
> 
> I’d add a Fixes: tag, but the maintainers might have more input.

Yes, I should have added Fixes: tag. I will leave it to the maintainer
to decide if v2 is needed to fix the spelling mistakes and add Fixes
tag.

Fixes: 5dfd37c37a44 ("i40e: Split i40e_osdep.h")

> 
> > Signed-off-by: Mohamed Khalfella <mkhalfella@xxxxxxxxxxxxxxx>
> > ---
> >   drivers/net/ethernet/intel/i40e/i40e_debug.h | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/net/ethernet/intel/i40e/i40e_debug.h b/drivers/net/ethernet/intel/i40e/i40e_debug.h
> > index e9871dfb32bd..01fd70db9086 100644
> > --- a/drivers/net/ethernet/intel/i40e/i40e_debug.h
> > +++ b/drivers/net/ethernet/intel/i40e/i40e_debug.h
> > @@ -42,7 +42,7 @@ struct device *i40e_hw_to_dev(struct i40e_hw *hw);
> >   #define i40e_debug(h, m, s, ...)				\
> >   do {								\
> >   	if (((m) & (h)->debug_mask))				\
> > -		dev_info(i40e_hw_to_dev(hw), s, ##__VA_ARGS__);	\
> > +		dev_info(i40e_hw_to_dev(h), s, ##__VA_ARGS__);	\
> >   } while (0)
> >   
> >   #endif /* _I40E_DEBUG_H_ */
> 
> Reviewed-by: Paul Menzel <pmenzel@xxxxxxxxxxxxx>
> 
> 
> Kind regards,
> 
> Paul
> 
> 
> PS: gemini/gemini-3.1-pro-preview embargoed it’s review until the 
> evening [1].
> 
> 
> [1]: 
> https://sashiko.dev/#/patchset/20260428181450.2622899-1-mkhalfella%40purestorage.com