Re: [PATCH v4 06/13] iio: dac: ad5686: refactor include headers

[Jonathan Cameron]

On Wed, 29 Apr 2026 16:38:02 +0200
Joshua Crofts <joshua.crofts1@xxxxxxxxx> wrote:

> On Wed, 29 Apr 2026 at 16:14, Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxx> wrote:
> > I haven't checked this deeply, but I hope at some point we will have
> > more or less usable state of `iwyu` tool that may do this automatically.
> > At least current result looks better than the original.
> >
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>  
> 
> I did find a "filter" file of sorts for IWYU that Jonathan had on the
> mailing list.
> It does a good job of omitting reports of very low level headers but at the
> same time IWYU still tells you to include things like <linux/stddef.h> and
> remove anything <asm/*>  from your includes. Perhaps it needs more
> tweaking?
> 

I ran into a few corners that I couldn't get to work right
+ probably didn't cover enough of the asm files with specific rules.

I'd love a canonical config file (at least for IIO).

Also turns out the LLMs are quite good at reviewing these patches

Jonathan