Re: [PATCH] media: verisilicon: Fix format enumeration when post-processor is mandatory
From: Nicolas Dufresne
Date: Wed Apr 29 2026 - 14:05:44 EST
Hi Benjamin,
Le mardi 28 avril 2026 à 10:37 +0200, Benjamin Gaignard a écrit :
> When a post-processor pixel format is mandatory (i.e. when an AV1
> bitstream use film grain feature) the driver must only enumerate
> post-processed format.
> Use the context format to know what is suppose to be enumerated.
>
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@xxxxxxxxxxxxx>
> Fixes: 80c7373a456e ("media: verisilicon: Conditionally ignore native
> formats")
> ---
> drivers/media/platform/verisilicon/hantro_v4l2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/verisilicon/hantro_v4l2.c
> b/drivers/media/platform/verisilicon/hantro_v4l2.c
> index fcf3bd9bcda2..f538d4562744 100644
> --- a/drivers/media/platform/verisilicon/hantro_v4l2.c
> +++ b/drivers/media/platform/verisilicon/hantro_v4l2.c
> @@ -242,7 +242,7 @@ static int vidioc_enum_fmt(struct file *file, void *priv,
> */
> skip_mode_none = capture == ctx->is_encoder;
>
> - formats = hantro_get_formats(ctx, &num_fmts, HANTRO_AUTO_POSTPROC);
> + formats = hantro_get_formats(ctx, &num_fmts, ctx->need_postproc);
Looks like this is a subset of another of your patch, which was pending a commit
message fix.
https://patchwork.linuxtv.org/project/linux-media/patch/20250624122938.62004-1-benjamin.gaignard@xxxxxxxxxxxxx/
I've picked the other patch and applied my commit message suggestion.
Nicolas
> for (i = 0; i < num_fmts; i++) {
> bool mode_none = formats[i].codec_mode == HANTRO_MODE_NONE;
> fmt = &formats[i];
Attachment:
signature.asc
Description: This is a digitally signed message part