Re: [PATCH v4 06/13] iio: dac: ad5686: refactor include headers

[Andy Shevchenko]

On Wed, Apr 29, 2026 at 04:38:02PM +0200, Joshua Crofts wrote:
> On Wed, 29 Apr 2026 at 16:14, Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxx> wrote:
> > I haven't checked this deeply, but I hope at some point we will have
> > more or less usable state of `iwyu` tool that may do this automatically.
> > At least current result looks better than the original.
> >
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
> 
> I did find a "filter" file of sorts for IWYU that Jonathan had on the
> mailing list.
> It does a good job of omitting reports of very low level headers but at the
> same time IWYU still tells you to include things like <linux/stddef.h> and
> remove anything <asm/*>  from your includes. Perhaps it needs more
> tweaking?

You need to check that manually and then decide if we need more amendments
either in the patch or in the `iwyu` "filter" file or in both. In case of
filter file changes, please share them to Jonathan and mailing list, so other
people can adjust their work in case they use the tool.

-- 
With Best Regards,
Andy Shevchenko