Re: [PATCH net-next v3] net: phy: realtek: support MDI swapping for RTL8226-CG

[Andrew Lunn]

> +	if (!swap_enable) {
> +		/* Patching is only implemented one-way, see next comment. */
> +		phydev_warn(phydev, "MDI swapping disabled, but PHY is already patched.\n");
> +		return -EINVAL;
> +	}

This appears to cause the probe to fail? If so, it should really be
phydev_err().

Otherwise this looks O.K.

    Andrew

---
pw-bot: cr