Re: [PATCH 2/2] regulator: add SGM3804 Dual Output driver

From: Mark Brown

Date: Wed Apr 29 2026 - 21:06:51 EST


On Wed, Apr 29, 2026 at 10:05:33AM +0200, Neil Armstrong wrote:
> On 4/29/26 02:37, Mark Brown wrote:
> > On Tue, Apr 28, 2026 at 03:52:06PM +0200, Neil Armstrong wrote:

> > > +// SPDX-License-Identifier: GPL-2.0-only
> > > +/*
> > > + * SGMicro SGM3804 regulator Driver
> > > + *
> > > + * Copyright (C) 2025 Kancy Joe <kancy2333@xxxxxxxxxxx>
> > > + * Copyright (C) 2026 Linaro Limited
> > > + * Author: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> > > + */

> > Please make the entire comment a C++ one so things look more
> > intentional. The authorship overall appears a bit confused?

> Sorry, what's confusing here ?

At various times both you and Kancy Joe are listed as authors of the
driver, but rarely both of you simulataneously. I can't tell what your
roles were here.

Attachment: signature.asc
Description: PGP signature