Re: [PATCH RESEND 1/2] powerpc/ps3: Drop redundant result assignment

From: Madhavan Srinivasan

Date: Wed Apr 29 2026 - 23:39:08 EST



On 4/29/26 11:33 AM, Michael Ellerman wrote:
On 28/4/2026 23:22, Krzysztof Kozlowski wrote:
On 17/03/2026 14:08, Krzysztof Kozlowski wrote:
Return value of ps3_start_probe_thread() is not used, so code can be
simplified to fix W=1 clang warnings:

   arch/powerpc/platforms/ps3/device-init.c:953:6: error: variable 'result' set but not used [-Werror,-Wunused-but-set-variable]

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
---

Resend after ~2.5 months

  arch/powerpc/platforms/ps3/device-init.c | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)

Ping. This also got a review.

I do not plan to resend second time... And I also understand if this is
somehow legacy and fixing warnings is not desired, but then it would be
great if you just responded "don't send such patches" and I would not
waste my time.

Thanks for the patch, sorry it hasn't been picked up.

I have been AWOL, and I suspect Maddy is not sure about taking PS3 patches directly without hearing from Geoff.

Maddy this is fine to pick up for next.

Yep will pick it my in the -rc cycle.

Thanks


cheers