RE: [PATCH 1/1] dt-bindings: net: wireless: intel,iwlwifi: add binding

[Bhatt, Avinash]

Hi Krzysztof,

Thank you for the review. Responses inline.

On 29/04/2026 10:14, Krzysztof Kozlowski wrote:
> On 29/04/2026 10:14, Avinash Bhatt wrote:
>> Add a devicetree schema binding for Intel discrete Wi-Fi 7 BE200 PCIe
>> adapters.
>
> Why? Where is any user of that?

The driver implementation consuming these properties exists and will be
submitted as a companion series together with v2 of this binding.

>> +  - linux-wireless@xxxxxxxxxxxxxxx
>
> Drop this one.

Ack. Will address in PATCH v2.

>> +description:
>> +  Intel iwlwifi IEEE 802.11be discrete Wi-Fi adapters connected over PCIe.
>
> Please wrap code according to the preferred limit expressed in Kernel
> coding style (checkpatch is not a coding style description, but only a
> tool). However don't wrap blindly (see Kernel coding style).

Ack. Will address in PATCH v2.

>> +  These bindings provide OEM platform configuration for platforms that
>> +  use Device Tree.
>
> Drop. Describe hardware.

Ack. Will address in PATCH v2.

>> +  intel,activate-channel:
>> ...
>> +  intel,force-disable-channels:
>
> I don't see how this is a DT property. Actually most of the properties
> do not look either. Do you want to say, that if I go with my device from
> EU to US on a business trip, I will need to recompile DTB? Obviously
> no...

These properties describe how the WiFi NIC was integrated into the
system by the OEM — specifically, which regulatory certifications were
obtained for this hardware SKU at manufacturing time. That is a fixed
hardware property of the board, no different from describing antenna
configuration or RF front-end capabilities.

To clarify the travel analogy: the regulatory domain (which country the
device is currently operating in) is determined at runtime by the kernel
regulatory subsystem, independently of these properties. What these
properties encode is what the hardware itself has been certified for.
For example, bit 0 of intel,activate-channel means "the OEM of this
board obtained EU indoor channel certification for this SKU." That
certification does not change when the device travels — it is a property
of the hardware, not of its location.

The per-country granularity exists because regulatory certifications are
issued independently by each country's agency (FCC for the USA, ISED
for Canada, etc.), so each country's enablement is a separate OEM
decision reflected in the board design.


Best regards,
Avinash

-----Original Message-----
From: Krzysztof Kozlowski <krzk@xxxxxxxxxx> 
Sent: 29 April 2026 13:49
To: Bhatt, Avinash <avinash.bhatt@xxxxxxxxx>; devicetree@xxxxxxxxxxxxxxx
Cc: linux-wireless@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; robh@xxxxxxxxxx; krzk+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx; johannes@xxxxxxxxxxxxxxxx; Korenblit, Miriam Rachel <miriam.rachel.korenblit@xxxxxxxxx>; Guetta, Kobi <kobi.guetta@xxxxxxxxx>; Grumbach, Emmanuel <emmanuel.grumbach@xxxxxxxxx>
Subject: Re: [PATCH 1/1] dt-bindings: net: wireless: intel,iwlwifi: add binding

On 29/04/2026 10:14, Avinash Bhatt wrote:
> Add a devicetree schema binding for Intel discrete Wi-Fi 7 BE200 PCIe 
> adapters.

Why? Where is any user of that?

> 
> The binding documents OEM platform configuration properties for 
> platforms that use Device Tree instead of platform firmware methods. 
> All properties mirror the existing equivalents in structure and 
> semantics, covering SAR power limits (intel,wrds),
> 6 GHz AP type support (intel,uats), static power limit (intel,splc), 
> channel puncturing (intel,wcpe), 320 MHz per-MCC enablement 
> (intel,wbem), ETSI SRD channel configuration (intel,srd), 6-7 GHz UHB 
> country enable bitmask (intel,6e-uhb), and additional regulatory 
> override properties.
> 
> Signed-off-by: Avinash Bhatt <avinash.bhatt@xxxxxxxxx>
> ---
>  .../bindings/net/wireless/intel,iwlwifi.yaml  | 445 
> ++++++++++++++++++
>  1 file changed, 445 insertions(+)
>  create mode 100644 
> Documentation/devicetree/bindings/net/wireless/intel,iwlwifi.yaml
> 
> diff --git 
> a/Documentation/devicetree/bindings/net/wireless/intel,iwlwifi.yaml 
> b/Documentation/devicetree/bindings/net/wireless/intel,iwlwifi.yaml
> new file mode 100644
> index 000000000000..d97be6cc35d8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/wireless/intel,iwlwifi.yam
> +++ l
> @@ -0,0 +1,445 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) # Copyright 
> +(c) 2026 Intel Corporation %YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/wireless/intel,iwlwifi.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Intel iwlwifi PCIe Wi-Fi devices
> +
> +maintainers:
> +  - Avinash Bhatt <avinash.bhatt@xxxxxxxxx>
> +  - linux-wireless@xxxxxxxxxxxxxxx

Drop this one.

> +
> +description:
> +  Intel iwlwifi IEEE 802.11be discrete Wi-Fi adapters connected over PCIe.

Please wrap code according to the preferred limit expressed in Kernel coding style (checkpatch is not a coding style description, but only a tool).  However don't wrap blindly (see Kernel coding style).

> +  These bindings provide OEM platform configuration for platforms that use Device Tree.

Drop. Describe hardware.

> +
> +properties:
> +  compatible:
> +    enum:
> +      - pci8086,272b
> +

...

> +
> +  intel,activate-channel:
> +    description: |
> +      Indoor channel activation bitmask. Sets specific frequency bands to
> +      active (rather than passive or disabled) when the platform is
> +      confirmed to be operating indoors.
> +
> +      Layout (2 cells):
> +        [0] revision - structure revision, must be 0x00
> +        [1] bitmap   - per-region indoor activation flags:
> +                       bit 0 = enable EU U-NII-1 (5.2 GHz) for indoors only
> +                       bit 1 = enable Japan U-NII-1 (5.2 GHz) for indoors only
> +                       bit 2 = enable China Mainland U-NII-1 (5.2 GHz) for indoors only
> +                       bit 3 = enable USA U-NII-4 (5.9 GHz) for indoors only
> +                       bit 4 = enable WW U-NII-1 (5.2 GHz) for indoors in any
> +                               country where the band is permitted
> +                       bit 5 = enable Canada U-NII-4 (5.9 GHz) for indoors only
> +                       bit 6 = enable USA + Canada + WW U-NII-4 (5.9 GHz) for
> +                               indoors only
> +                       bits 7-31: reserved, must be 0
> +    allOf:
> +      - $ref: /schemas/types.yaml#/definitions/uint32-array
> +      - minItems: 2
> +        maxItems: 2
> +        items:
> +          - const: 0
> +
> +  intel,force-disable-channels:

I don't see how this is a DT property. Actually most of the properties do not look either. Do you want to say, that if I go with my device from EU to US on a business trip, I will need to recompile DTB? Obviously no...

Best regards,
Krzysztof