Re: [PATCH v4 2/2] platform/x86: x86-android-tablets: enable fwnode matching of GPIO chips

[Andy Shevchenko]

On Thu, Apr 30, 2026 at 03:51:58PM +0300, Andy Shevchenko wrote:
> On Thu, Apr 30, 2026 at 09:34:06AM +0200, Bartosz Golaszewski wrote:

...

> > +	for (swnode = gpiochip_node_group; *swnode; swnode++) {
> > +		struct device *dev __free(put_device) =
> > +				acpi_bus_find_device_by_name((*swnode)->name);
> > +		if (!dev) {
> > +			dev_err(parent, "Failed to find the required GPIO controller: %s\n",
> > +				(*swnode)->name);
> 
> swnode at this point is registered, meaning we have an associated fwnode
> handle, hence why not use %pfwP here?

After reading the code again I think your version is KISS, no need for over
engineering :-)

> > +			return -ENODEV;
> > +		}

-- 
With Best Regards,
Andy Shevchenko