Re: [PATCH v2 08/15] serial: earlycon: use uart_iotype_*() to simplify code
From: Andy Shevchenko
Date: Thu Apr 30 2026 - 11:03:46 EST
On Tue, Apr 28, 2026 at 01:53:54PM -0400, Hugo Villeneuve wrote:
> Make use of new functions uart_iotype_mmio() and uart_iotype_legacy_io()
> to simplify and improve code readability.
...
> + char address[64] = "";
TBH, I prefer two pr_info() calls as that approach
- doesn't require temporary buffer
- doesn't use heavy s*printf() on top of the existing printing
- doesn't limit the flexibility of each of the strings (64 might
become not enough in some cases, however unlikely to happen)
--
With Best Regards,
Andy Shevchenko