Re: [PATCH v2] bitops: use correct parameter names in kernel-doc

From: Yury Norov

Date: Thu Apr 30 2026 - 20:11:45 EST


On Thu, Apr 30, 2026 at 04:39:34PM -0700, Randy Dunlap wrote:
> Fix the kernel-doc comments to use the correct parameter names to
> avoid kernel-doc warnings:
>
> Warning: include/asm-generic/bitops/lock.h:19 function parameter 'p'
> not described in 'arch_test_and_set_bit_lock'
> Warning: include/asm-generic/bitops/lock.h:41 function parameter 'p'
> not described in 'arch_clear_bit_unlock'
> Warning: include/asm-generic/bitops/lock.h:59 function parameter 'p'
> not described in 'arch___clear_bit_unlock'
>
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>

Hi Randy,

Thanks for the patch!

The arches implementing those functions use 'addr', not 'p'. In
generic version originally it was 'addr, but then the functions
were re-implemented in 84c6591103dbe, thus this 'p' appeared.

Maybe just restore this 'addr' instead of fixing comments?

Thanks,
Yury