Re: [PATCH net-next 00/11] net: devmem: support devmem with netkit devices
From: Bobby Eshleman
Date: Thu Apr 30 2026 - 21:04:37 EST
On Thu, Apr 30, 2026 at 05:59:45PM -0700, Jakub Kicinski wrote:
> On Tue, 28 Apr 2026 15:41:57 -0700 Bobby Eshleman wrote:
> > net: add netmem_tx modes that indicate dma capability
> > net: bnxt: convert netmem_tx from bool to NETMEM_TX_DMA enum
> > gve: convert netmem_tx from bool to NETMEM_TX_DMA enum
> > net/mlx5e: convert netmem_tx from bool to NETMEM_TX_DMA enum
> > eth: fbnic: convert netmem_tx from bool to NETMEM_TX_DMA enum
> > netkit: set NETMEM_TX_NO_DMA for unreadable skb passthrough
> > net: devmem: support TX over NETMEM_TX_NO_DMA devices
>
> I think it looks reasonable over all, but the assumption that rx lease
> implies tx queue does not seem great. Sounds like Daniel has that part
> covered tho :)
Indeed, with TX leasing this becomes much nicer.
>
> When you post v2 - you can squash the driver patches into patch 1.
Will do!
Best,
Bobby