Re: [PATCH v4 1/5] dt-bindings: leds: Document TI LM3560 Synchronous Boost Flash Driver

[Svyatoslav Ryhel]

чт, 30 квіт. 2026 р. о 23:42 Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> пише:
>
> Hi Svyatoslav,
>
> On Tue, Apr 28, 2026 at 02:39:18PM +0300, Svyatoslav Ryhel wrote:
> > +  flash-max-timeout-us:
> > +    minimum: 32000
> > +    maximum: 1024000
> > +    default: 32000
> > +
> > +  ti,peak-current-microamp:
> > +    description:
> > +      The LM3560 features 4 selectable current limits 1.6A, 2.3A, 3A, and 3.6A.
> > +      When the current limit is reached, the LM3560 stops switching for the
> > +      remainder of the switching cycle.
> > +    enum: [1600000, 2300000, 3000000, 3600000]
> > +    default: 1600000
>
> I missed earlier these limits are of course incorrect for lm3559. These
> would need to be changed for the lm3559, too. I'd just drop that compatible
> for now.
>
> I can do that while applying the patches if you're fine with that.
>

I appreciate your efforts, but removing this property will lock both
lm3559 and lm3560 in the lowest current which may cause malfunction
when driving more powerful dual LED configuration.

I will address lm3559 handling in the driver and I will send v5 as
soon as it is ready and tested (since I don't have lm3559 I will test
on lm3560 but they will have same mechanism just different values so
it should be enough). Will this be acceptable for you?

> --
> Regards,
>
> Sakari Ailus