Re: [PATCH net v2 2/2] selftests: openvswitch: add tests for tunnel vport refcounting
From: Eelco Chaudron
Date: Fri May 01 2026 - 04:56:37 EST
On 1 May 2026, at 1:38, Ilya Maximets wrote:
> There were a few issues found with the tunnel vport types around the
> vport destruction code. Add some basic tests, so at least we know that
> they can be properly added and removed without obvious issues.
>
> The test creates OVS datapath, adds a non-LWT tunnel port, makes sure
> they are created, and then removes the datapath and waits for all the
> ports to be gone.
>
> The dpctl script had a few bugs in the none-lwt tunnel creation code,
> so fixing them as well to make the testing possible:
> - The type of the --lwt option changed in order to properly disable it.
> - Removed byte order conversion for the port numbers, as the value
> supposed to be in the host order.
> - Added missing 'gre' choice for the tunnel type.
>
> Signed-off-by: Ilya Maximets <i.maximets@xxxxxxx>
Changes on the v2 look good to me!
Acked-by: Eelco Chaudron <echaudro@xxxxxxxxxx>