Re: [PATCH] PCI: brcmstb: Assign pcie->gen from pcie_get_link_speed()
From: Florian Fainelli
Date: Fri May 01 2026 - 18:05:19 EST
On 5/1/26 15:03, Bjorn Helgaas wrote:
On Fri, May 01, 2026 at 01:24:38PM -0700, Florian Fainelli wrote:
After commit 03f920936977 ("PCI: controller: Validate max-link-speed"),
pcie->gen stopped being assigned and as a result the established PCIe
link would stop supporting Gen3 speeds on 2712 since pcie->gen is used
to populate LnkCntl2 and LnkCap in brcm_pcie_set_gen().
Link: https://github.com/raspberrypi/linux/issues/7343
Reported-by: Dom Cobley <popcornmix@xxxxxxxxx>
Reported-by: Phil Elwell <phil@xxxxxxxxxxxxxxx>
Fixes: 03f920936977 ("PCI: controller: Validate max-link-speed")
Signed-off-by: Florian Fainelli <florian.fainelli@xxxxxxxxxxxx>
Applied to pci/for-linus for v7.1, thanks, and sorry for the breakage.
I reviewed the original change and completely missed that, so no worries, the fault is mine to have missed it in the first place. Thanks for fast tracking this!
--
Florian