Re: [PATCH] rust: io: use newtype for PhysAddr
From: Onur Özkan
Date: Sun May 03 2026 - 14:52:28 EST
On Sun, 03 May 2026 20:45:50 +0200
Danilo Krummrich <dakr@xxxxxxxxxx> wrote:
> On Sun May 3, 2026 at 8:28 PM CEST, Onur Özkan wrote:
> > Copy and Clone seem never used, please drop them (also see [1]).
>
> This is a transparent wrapper of a primitive, so passing by value is a very
> natural and idiomatic thing to do, so we should keep them.
Right, my bad. I didn't pay attention to the type itself.
>
> What you are referring to is more meant for larger types where a copy might
> actually hurt performance.