Re: [PATCH 2/2] pinctrl: qcom: Add Shikra pinctrl driver

[Komal Bajaj]

On 4/30/2026 4:24 PM, Konrad Dybcio wrote:
> On 4/30/26 6:06 AM, Maulik Shah (mkshah) wrote:
> > On 4/29/2026 6:41 PM, Komal Bajaj wrote:
> > > Add pinctrl driver for TLMM block found in Shikra SoC.
> [...]
>
>
> > > +static const struct msm_gpio_wakeirq_map shikra_mpm_map[] = {
> > > +	{1, 9},    {2, 31},   {5, 49},   {6, 53},   {9, 72},   {10, 10},
> > It would be better to have spacing before/after brackets inline with other pinctrl drivers.
> > {1, 9}, should be { 1, 9 }.
> If that's also something that the generator takes care of, let's fix
> it there too

Sure, we will try to take care of this in the generator to avoid such 
cases going forward.

Thanks
Komal

> Konrad