Re: [PATCH v2 2/5] iio: adc: add Versal SysMon driver

[Guenter Roeck]

On 5/4/26 10:32, Jonathan Cameron wrote:
> On Sat, 2 May 2026 12:19:48 +0100
> Salih Erim <salih.erim@xxxxxxx> wrote:
>
> > Add the AMD/Xilinx Versal System Monitor (SysMon) IIO driver.
> >
> > The driver is split into a bus-agnostic core module
> > (versal-sysmon-core) and a memory-mapped I/O platform driver
> > (versal-sysmon). The core uses the regmap API so that different
> > bus implementations can share the same IIO logic.
> >
> > The core provides:
> >    - Static temperature channels (current max/min, peak max/min)
> >    - Supply voltage channels parsed from DT container nodes
> >    - Temperature satellite channels parsed from DT container nodes
> >    - read_raw for IIO_CHAN_INFO_RAW and IIO_CHAN_INFO_PROCESSED
> >    - read_label using the DT label property
>
> Various comments inline.  One thing to check.
> Is this one strictly a hardware monitoring device? Or does it
> get used for more general ADC purposes?  Did you consider an HWMON driver
> for it? The above sounds a lot like hwmon. So why IIO for this one?
>
> I wasn't awake enough on v1 to raise this!  Sorry about that.
> +CC Guenter and linux-hwmon for that discussion.

This very much sounds like a hardware monitoring device to me.

Guenter