Re: [PATCH v2 24/53] klp-build: Fix checksum comparison for changed offsets
From: Miroslav Benes
Date: Tue May 05 2026 - 06:15:17 EST
On Thu, 30 Apr 2026 21:08:12 -0700, Josh Poimboeuf <jpoimboe@xxxxxxxxxx> wrote:
> The klp-build -f/--show-first-changed feature uses diff to compare
> checksum log lines between original and patched objects. However, diff
> compares entire lines, including the offset field. When a function is
> at a different section offset, the offset field differs even though the
> instruction checksum is identical, causing the wrong instruction to be
> printed.
>
> [...]
Reviewed-by: Miroslav Benes <mbenes@xxxxxxx>
--
Miroslav