Re: [PATCH v1 1/7] rust: sync: completion: add wait_for_completion_timeout()
From: Miguel Ojeda
Date: Tue May 05 2026 - 08:17:45 EST
On Fri, May 1, 2026 at 10:58 PM Joel Fernandes <joelagnelf@xxxxxxxxxx> wrote:
>
> + // SAFETY: `self.as_raw()` is a pointer to a valid `struct completion`.
This is fine since it follows the other ones in the file, but we
should say why this is the case (in another series, possibly a good
first issue), rather than just asserting it.
e.g. a type invariant?
Cheers,
Miguel