Re: [PATCH v9 6/7] pinctrl: s32cc: implement GPIO functionality

[Linus Walleij]

Hi Khristine,

thanks for your patch!

On Mon, May 4, 2026 at 3:12 PM Khristine Andreea Barbulescu
<khristineandreea.barbulescu@xxxxxxxxxxx> wrote:

> From: Andrei Stefanescu <andrei.stefanescu@xxxxxxxxxxx>
>
> Add basic GPIO functionality (request, free, get, set) for
> the existing pinctrl SIUL2 driver since the hardware for
> pinctrl&GPIO is tightly coupled.
>
> The updated SIUL2 block groups pinctrl, GPIO data access
> and interrupt control within the same hardware unit.
> The SIUL2 driver is therefore structured as a monolithic
> pinctrl/GPIO driver.
>
> This change came as a result of upstream review in the
> following series:
> https://lore.kernel.org/linux-gpio/20260120115923.3463866-4-khristineandreea.barbulescu@xxxxxxxxxxx/T/#m543c9edbdde74bdc68b6a2364e8b975356c33043
>
> Support both SIUL2 DT layouts:
> - legacy pinctrl-only binding
> - extended pinctrl/GPIO/irqchip binding
>
> Also, remove pinmux_ops which are no longer needed.
>
> Signed-off-by: Andrei Stefanescu <andrei.stefanescu@xxxxxxxxxxx>
> Signed-off-by: Khristine Andreea Barbulescu <khristineandreea.barbulescu@xxxxxxxxxxx>

Same comment about GPIO_REGMAP here.

Maybe this has been brought up before so it's just sigh rolleyes,
but my memory is short.

Of course gpio regmap conversions can be done later, after this,
but the problem with such things is that they tend to end up on
the back burner and never actually get done then.

Yours,
Linus Walleij