Re: [PATCH 0/6] media: v4l2-isp: Add support for extensible statistics

[Antoine Bouyer]

On 5/5/26 4:12 PM, Jacopo Mondi wrote:
> This series breaks out from Antonie's
> https://patchwork.linuxtv.org/project/linux-media/list/?series=24043
> the extensible stats support and adds a few more patches on top to:
>
> - add support for per-block validation as suggested during the review of
>    Ricardo's
>    https://patchwork.linuxtv.org/project/linux-media/patch/20260504-smatch-7-1-v3-6-fda125c30058@xxxxxxxxxxxx/
>
> - add two helper functions to v4l2-isp to ease handling of extensible
>    statistics for drivers. An early user, based on a preliminary version
>    of the patches is available here as a reference:
>    https://patchwork.linuxtv.org/project/linux-media/list/?series=24703
>
> Antonie: I took the liberty to fold in your patches changes to address
> my comments on your v1. I pushed an un-squased version of the patches
> here:
> https://gitlab.freedesktop.org/linux-media/users/jmondi/-/tree/b4/extensible-stats-unsquashed
> so you can easily get the diff from this and your version. Please feel
> free to comment on these as you're the original author.

Hi Jacopo

Thanks for the rework and the links. I'm fine with your [SQUASH] commits.

If there are no other comments, I assume I can reuse the common patches 
in my v2 then, and also apply the new helpers to neoisp driver changes. 
They look very useful (especially to prevent out-of-bounds crashes I 
observed when data_size was not set before filling stats :( ). I'll 
check in your user example.

BR
Antoine

> Signed-off-by: Jacopo Mondi <jacopo.mondi@xxxxxxxxxxxxxxxx>
> ---
> Antoine Bouyer (2):
>        media: uapi: v4l2-isp: Add extensible statistics
>        media: Documentation: uapi: Update V4L2 ISP for extensible stats
>
> Jacopo Mondi (4):
>        media: v4l2-isp: Rename v4l2_isp_params_buffer_size
>        media: v4l2-isp: Add per-block validation callback
>        media: amlogic-c3: Implement per-block validation
>        media: v4l2-isp: Add helpers for stats buffer
>
>   Documentation/userspace-api/media/v4l/v4l2-isp.rst |  45 ++++++--
>   .../media/platform/amlogic/c3/isp/c3-isp-params.c  |  42 ++++++-
>   .../media/platform/arm/mali-c55/mali-c55-params.c  |  12 +-
>   drivers/media/v4l2-core/v4l2-isp.c                 |  56 +++++++++
>   include/media/v4l2-isp.h                           |  94 +++++++++++++---
>   include/uapi/linux/media/v4l2-isp.h                | 125 +++++++++++++--------
>   6 files changed, 294 insertions(+), 80 deletions(-)
> ---
> base-commit: d9c8c4adf23d17549c0ec9c85b99d85a0ee6cf18
> change-id: 20260504-extensible-stats-f2d6befcc1ce
>
> Best regards,
> --
> Jacopo Mondi <jacopo.mondi@xxxxxxxxxxxxxxxx>