Re: [PATCH v2] crypto: ecc - Unbreak the build on arm with CONFIG_KASAN_STACK=y
From: Andy Shevchenko
Date: Wed May 06 2026 - 10:13:33 EST
On Wed, May 06, 2026 at 03:56:22PM +0200, Lukas Wunner wrote:
> On Wed, May 06, 2026 at 04:42:25PM +0300, Andy Shevchenko wrote:
> > On Wed, May 06, 2026 at 03:27:49PM +0200, Lukas Wunner wrote:
> > > A longterm solution is to refactor ecc.c for reduced stack usage. It
> > > currently performs ECC point multiplication with a Montgomery ladder
> > > which uses co-Z (conjugate) addition to trade off memory for speed.
> > > The algorithm is susceptible to timing attacks and needs to be replaced
> > > with a constant time Montgomery ladder, which should consume less memory
> > > and thus resolve the stack usage issue as a side effect.
[...]
> > > +# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=124949
> >
> > Perhaps also mention the algo change as that one sounds to me even more
> > critical than this issue per se.
>
> Hm, but it's already mentioned above in the commit message?
Commit message != Makefile (or any other in-tree file).
But if you think that this is enough, I am not going to object, it would just
require a few steps to get that from the line in file.
--
With Best Regards,
Andy Shevchenko