Re: [PATCH v5 09/18] iio: magnetometer: ak8975: avoid using temporary variable

[Jonathan Cameron]

On Tue, 05 May 2026 13:46:05 +0200
Joshua Crofts via B4 Relay <devnull+joshua.crofts1.gmail.com@xxxxxxxxxx> wrote:

> From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> 
> Avoid using temporary variable in ak8975_read_axis(). With that being done,
> the clamp_t() call becomes idiomatic in the driver and can be factored out
> to a helper later on (and if needed).
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Signed-off-by: Joshua Crofts <joshua.crofts1@xxxxxxxxx>
Independent of the last two patches (which I've left for now)
so applied this one to the testing branch of iio.git.

Jonathan

> ---
>  drivers/iio/magnetometer/ak8975.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/magnetometer/ak8975.c b/drivers/iio/magnetometer/ak8975.c
> index b3caf5f3ebf29bf701bb214aa480fa7afb2651c6..c36d068081066ef6b42cc2f9c3c2e8978ec51623 100644
> --- a/drivers/iio/magnetometer/ak8975.c
> +++ b/drivers/iio/magnetometer/ak8975.c
> @@ -741,7 +741,6 @@ static int ak8975_read_axis(struct iio_dev *indio_dev, int index, int *val)
>  	const struct i2c_client *client = data->client;
>  	const struct ak_def *def = data->def;
>  	__le16 rval;
> -	u16 buff;
>  	int ret;
>  
>  	pm_runtime_get_sync(&data->client->dev);
> @@ -778,8 +777,8 @@ static int ak8975_read_axis(struct iio_dev *indio_dev, int index, int *val)
>  	pm_runtime_put_autosuspend(&data->client->dev);
>  
>  	/* Swap bytes and convert to valid range. */
> -	buff = le16_to_cpu(rval);
> -	*val = clamp_t(s16, buff, -def->range, def->range);
> +	*val = clamp_t(s16, le16_to_cpu(rval), -def->range, def->range);
> +
>  	return IIO_VAL_INT;
>  
>  exit:
>