Re: [PATCH v2 2/6] ASoC: qcom: qdsp6: q6routing: add Senary MI2S ports

From: Srinivas Kandagatla

Date: Thu May 07 2026 - 04:37:44 EST


On 5/6/26 8:33 PM, Val Packett wrote:
> This commit adds support for senary MI2S mixers.
>
> Signed-off-by: Val Packett <val@xxxxxxxxxxxx>
> ---

lgtm,

Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxxxxxxxx>

> sound/soc/qcom/qdsp6/q6routing.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/sound/soc/qcom/qdsp6/q6routing.c b/sound/soc/qcom/qdsp6/q6routing.c
> index 7386226046fa..55119cc33d95 100644
> --- a/sound/soc/qcom/qdsp6/q6routing.c
> +++ b/sound/soc/qcom/qdsp6/q6routing.c
> @@ -68,6 +68,7 @@
> { mix_name, "SEC_MI2S_TX", "SEC_MI2S_TX" }, \
> { mix_name, "QUAT_MI2S_TX", "QUAT_MI2S_TX" }, \
> { mix_name, "QUIN_MI2S_TX", "QUIN_MI2S_TX" }, \
> + { mix_name, "SEN_MI2S_TX", "SEN_MI2S_TX" }, \
> { mix_name, "TERT_MI2S_TX", "TERT_MI2S_TX" }, \
> { mix_name, "SLIMBUS_0_TX", "SLIMBUS_0_TX" }, \
> { mix_name, "SLIMBUS_1_TX", "SLIMBUS_1_TX" }, \
> @@ -145,6 +146,9 @@
> SOC_SINGLE_EXT("QUIN_MI2S_TX", QUINARY_MI2S_TX, \
> id, 1, 0, msm_routing_get_audio_mixer, \
> msm_routing_put_audio_mixer), \
> + SOC_SINGLE_EXT("SEN_MI2S_TX", SENARY_MI2S_TX, \
> + id, 1, 0, msm_routing_get_audio_mixer, \
> + msm_routing_put_audio_mixer), \
> SOC_SINGLE_EXT("SLIMBUS_0_TX", SLIMBUS_0_TX, \
> id, 1, 0, msm_routing_get_audio_mixer, \
> msm_routing_put_audio_mixer), \
> @@ -535,6 +539,9 @@ static const struct snd_kcontrol_new quaternary_mi2s_rx_mixer_controls[] = {
> static const struct snd_kcontrol_new quinary_mi2s_rx_mixer_controls[] = {
> Q6ROUTING_RX_MIXERS(QUINARY_MI2S_RX) };
>
> +static const struct snd_kcontrol_new senary_mi2s_rx_mixer_controls[] = {
> + Q6ROUTING_RX_MIXERS(SENARY_MI2S_RX) };
> +
> static const struct snd_kcontrol_new tertiary_mi2s_rx_mixer_controls[] = {
> Q6ROUTING_RX_MIXERS(TERTIARY_MI2S_RX) };
>
> @@ -777,6 +784,9 @@ static const struct snd_soc_dapm_widget msm_qdsp6_widgets[] = {
> SND_SOC_DAPM_MIXER("QUIN_MI2S_RX Audio Mixer", SND_SOC_NOPM, 0, 0,
> quinary_mi2s_rx_mixer_controls,
> ARRAY_SIZE(quinary_mi2s_rx_mixer_controls)),
> + SND_SOC_DAPM_MIXER("SEN_MI2S_RX Audio Mixer", SND_SOC_NOPM, 0, 0,
> + senary_mi2s_rx_mixer_controls,
> + ARRAY_SIZE(senary_mi2s_rx_mixer_controls)),
> SND_SOC_DAPM_MIXER("TERT_MI2S_RX Audio Mixer", SND_SOC_NOPM, 0, 0,
> tertiary_mi2s_rx_mixer_controls,
> ARRAY_SIZE(tertiary_mi2s_rx_mixer_controls)),
> @@ -969,6 +979,7 @@ static const struct snd_soc_dapm_route intercon[] = {
> Q6ROUTING_RX_DAPM_ROUTE("SLIMBUS_6_RX Audio Mixer", "SLIMBUS_6_RX"),
> Q6ROUTING_RX_DAPM_ROUTE("QUAT_MI2S_RX Audio Mixer", "QUAT_MI2S_RX"),
> Q6ROUTING_RX_DAPM_ROUTE("QUIN_MI2S_RX Audio Mixer", "QUIN_MI2S_RX"),
> + Q6ROUTING_RX_DAPM_ROUTE("SEN_MI2S_RX Audio Mixer", "SEN_MI2S_RX"),
> Q6ROUTING_RX_DAPM_ROUTE("TERT_MI2S_RX Audio Mixer", "TERT_MI2S_RX"),
> Q6ROUTING_RX_DAPM_ROUTE("SEC_MI2S_RX Audio Mixer", "SEC_MI2S_RX"),
> Q6ROUTING_RX_DAPM_ROUTE("PRI_MI2S_RX Audio Mixer", "PRI_MI2S_RX"),