Re: [PATCH ipsec-next v8 02/14] xfrm: add extack to xfrm_init_state

From: Sabrina Dubroca

Date: Thu May 07 2026 - 06:40:13 EST


2026-05-05, 06:32:19 +0200, Antony Antony wrote:
> Add a struct extack parameter to xfrm_init_state() and pass it
> through to __xfrm_init_state(). This allows validation errors detected
> during state initialization to propagate meaningful error messages back
> to userspace.
>
> xfrm_state_migrate_create() now passes extack so that errors from the
> XFRM_MSG_MIGRATE_STATE path are properly reported. Callers without an
> extack context (af_key, ipcomp4, ipcomp6) pass NULL, preserving their
> existing behaviour.
>
> Signed-off-by: Antony Antony <antony.antony@xxxxxxxxxxx>
>
> ---
> v5->v6: added this patch
> ---
> include/net/xfrm.h | 2 +-
> net/ipv4/ipcomp.c | 2 +-
> net/ipv6/ipcomp6.c | 2 +-
> net/key/af_key.c | 2 +-
> net/xfrm/xfrm_state.c | 6 +++---
> 5 files changed, 7 insertions(+), 7 deletions(-)

Reviewed-by: Sabrina Dubroca <sd@xxxxxxxxxxxxxxx>

--
Sabrina