Re: [PATCH v5 05/14] mm: remove READ_ONLY_THP_FOR_FS Kconfig option
From: Lance Yang
Date: Thu May 07 2026 - 08:50:11 EST
On Wed, Apr 29, 2026 at 11:35:28AM -0400, Zi Yan wrote:
>After removing READ_ONLY_THP_FOR_FS check in file_thp_enabled(),
>khugepaged and MADV_COLLAPSE can run on FSes with PMD THP pagecache
>support even without READ_ONLY_THP_FOR_FS enabled. Remove the Kconfig first
>so that no one can use READ_ONLY_THP_FOR_FS as upcoming commits remove
>mapping->nr_thps, which its safe guard mechanism relies on.
>
>Signed-off-by: Zi Yan <ziy@xxxxxxxxxx>
>Reviewed-by: Lorenzo Stoakes (Oracle) <ljs@xxxxxxxxxx>
>Acked-by: David Hildenbrand (Arm) <david@xxxxxxxxxx>
>Reviewed-by: Baolin Wang <baolin.wang@xxxxxxxxxxxxxxxxx>
>---
READ_ONLY_THP_FOR_FS lost its job now that mapping_pmd_folio_support()
does the gating ;)
LGTM.
Reviewed-by: Lance Yang <lance.yang@xxxxxxxxx>