Re: [PATCH 02/13] media: imx355: Remove setting FRM_LENGTH_LINES in the mode regs

[Jacopo Mondi]

Hi Dave

On Wed, May 06, 2026 at 07:23:40PM +0100, Dave Stevenson wrote:
> Registers 0x0340 and 0x0341 (FRM_LENGTH_LINES) are already written
> from the set_ctrl(V4L2_CID_VBLANK) handler, so don't write them
> from the mode register list.
>
> Signed-off-by: Dave Stevenson <dave.stevenson@xxxxxxxxxxxxxxx>

Reviewed-by: Jacopo Mondi <jacopo.mondi@xxxxxxxxxxxxxxxx>

> ---
>  drivers/media/i2c/imx355.c | 28 ----------------------------
>  1 file changed, 28 deletions(-)
>
> diff --git a/drivers/media/i2c/imx355.c b/drivers/media/i2c/imx355.c
> index a694d4d742ae..8ea510218c7c 100644
> --- a/drivers/media/i2c/imx355.c
> +++ b/drivers/media/i2c/imx355.c
> @@ -256,8 +256,6 @@ static const struct imx355_reg_list imx355_global_setting = {
>  static const struct imx355_reg mode_3268x2448_regs[] = {
>  	{ 0x0342, 0x0e },
>  	{ 0x0343, 0x58 },
> -	{ 0x0340, 0x0a },
> -	{ 0x0341, 0x37 },
>  	{ 0x0344, 0x00 },
>  	{ 0x0345, 0x08 },
>  	{ 0x0346, 0x00 },
> @@ -280,8 +278,6 @@ static const struct imx355_reg mode_3268x2448_regs[] = {
>  static const struct imx355_reg mode_3264x2448_regs[] = {
>  	{ 0x0342, 0x0e },
>  	{ 0x0343, 0x58 },
> -	{ 0x0340, 0x0a },
> -	{ 0x0341, 0x37 },
>  	{ 0x0344, 0x00 },
>  	{ 0x0345, 0x08 },
>  	{ 0x0346, 0x00 },
> @@ -304,8 +300,6 @@ static const struct imx355_reg mode_3264x2448_regs[] = {
>  static const struct imx355_reg mode_3280x2464_regs[] = {
>  	{ 0x0342, 0x0e },
>  	{ 0x0343, 0x58 },
> -	{ 0x0340, 0x0a },
> -	{ 0x0341, 0x37 },
>  	{ 0x0344, 0x00 },
>  	{ 0x0345, 0x00 },
>  	{ 0x0346, 0x00 },
> @@ -328,8 +322,6 @@ static const struct imx355_reg mode_3280x2464_regs[] = {
>  static const struct imx355_reg mode_1940x1096_regs[] = {
>  	{ 0x0342, 0x0e },
>  	{ 0x0343, 0x58 },
> -	{ 0x0340, 0x05 },
> -	{ 0x0341, 0x1a },
>  	{ 0x0344, 0x02 },
>  	{ 0x0345, 0xa0 },
>  	{ 0x0346, 0x02 },
> @@ -352,8 +344,6 @@ static const struct imx355_reg mode_1940x1096_regs[] = {
>  static const struct imx355_reg mode_1936x1096_regs[] = {
>  	{ 0x0342, 0x0e },
>  	{ 0x0343, 0x58 },
> -	{ 0x0340, 0x05 },
> -	{ 0x0341, 0x1a },
>  	{ 0x0344, 0x02 },
>  	{ 0x0345, 0xa0 },
>  	{ 0x0346, 0x02 },
> @@ -376,8 +366,6 @@ static const struct imx355_reg mode_1936x1096_regs[] = {
>  static const struct imx355_reg mode_1924x1080_regs[] = {
>  	{ 0x0342, 0x0e },
>  	{ 0x0343, 0x58 },
> -	{ 0x0340, 0x05 },
> -	{ 0x0341, 0x1a },
>  	{ 0x0344, 0x02 },
>  	{ 0x0345, 0xa8 },
>  	{ 0x0346, 0x02 },
> @@ -400,8 +388,6 @@ static const struct imx355_reg mode_1924x1080_regs[] = {
>  static const struct imx355_reg mode_1920x1080_regs[] = {
>  	{ 0x0342, 0x0e },
>  	{ 0x0343, 0x58 },
> -	{ 0x0340, 0x05 },
> -	{ 0x0341, 0x1a },
>  	{ 0x0344, 0x02 },
>  	{ 0x0345, 0xa8 },
>  	{ 0x0346, 0x02 },
> @@ -424,8 +410,6 @@ static const struct imx355_reg mode_1920x1080_regs[] = {
>  static const struct imx355_reg mode_1640x1232_regs[] = {
>  	{ 0x0342, 0x07 },
>  	{ 0x0343, 0x2c },
> -	{ 0x0340, 0x05 },
> -	{ 0x0341, 0x1a },
>  	{ 0x0344, 0x00 },
>  	{ 0x0345, 0x00 },
>  	{ 0x0346, 0x00 },
> @@ -448,8 +432,6 @@ static const struct imx355_reg mode_1640x1232_regs[] = {
>  static const struct imx355_reg mode_1640x922_regs[] = {
>  	{ 0x0342, 0x07 },
>  	{ 0x0343, 0x2c },
> -	{ 0x0340, 0x05 },
> -	{ 0x0341, 0x1a },
>  	{ 0x0344, 0x00 },
>  	{ 0x0345, 0x00 },
>  	{ 0x0346, 0x01 },
> @@ -472,8 +454,6 @@ static const struct imx355_reg mode_1640x922_regs[] = {
>  static const struct imx355_reg mode_1300x736_regs[] = {
>  	{ 0x0342, 0x07 },
>  	{ 0x0343, 0x2c },
> -	{ 0x0340, 0x05 },
> -	{ 0x0341, 0x1a },
>  	{ 0x0344, 0x01 },
>  	{ 0x0345, 0x58 },
>  	{ 0x0346, 0x01 },
> @@ -496,8 +476,6 @@ static const struct imx355_reg mode_1300x736_regs[] = {
>  static const struct imx355_reg mode_1296x736_regs[] = {
>  	{ 0x0342, 0x07 },
>  	{ 0x0343, 0x2c },
> -	{ 0x0340, 0x05 },
> -	{ 0x0341, 0x1a },
>  	{ 0x0344, 0x01 },
>  	{ 0x0345, 0x58 },
>  	{ 0x0346, 0x01 },
> @@ -520,8 +498,6 @@ static const struct imx355_reg mode_1296x736_regs[] = {
>  static const struct imx355_reg mode_1284x720_regs[] = {
>  	{ 0x0342, 0x07 },
>  	{ 0x0343, 0x2c },
> -	{ 0x0340, 0x05 },
> -	{ 0x0341, 0x1a },
>  	{ 0x0344, 0x01 },
>  	{ 0x0345, 0x68 },
>  	{ 0x0346, 0x02 },
> @@ -544,8 +520,6 @@ static const struct imx355_reg mode_1284x720_regs[] = {
>  static const struct imx355_reg mode_1280x720_regs[] = {
>  	{ 0x0342, 0x07 },
>  	{ 0x0343, 0x2c },
> -	{ 0x0340, 0x05 },
> -	{ 0x0341, 0x1a },
>  	{ 0x0344, 0x01 },
>  	{ 0x0345, 0x68 },
>  	{ 0x0346, 0x02 },
> @@ -568,8 +542,6 @@ static const struct imx355_reg mode_1280x720_regs[] = {
>  static const struct imx355_reg mode_820x616_regs[] = {
>  	{ 0x0342, 0x0e },
>  	{ 0x0343, 0x58 },
> -	{ 0x0340, 0x02 },
> -	{ 0x0341, 0x8c },
>  	{ 0x0344, 0x00 },
>  	{ 0x0345, 0x00 },
>  	{ 0x0346, 0x00 },
>
> --
> 2.34.1
>
>