Re: [PATCH v4 1/3] dt-bindings: hwmon: pmbus: add Delta E50SN12051 binding
From: Colin Huang
Date: Fri May 08 2026 - 04:21:37 EST
Conor Dooley <conor@xxxxxxxxxx> 於 2026年5月8日週五 上午1:07寫道:
>
> On Thu, May 07, 2026 at 01:12:26PM +0800, Colin Huang via B4 Relay wrote:
> > From: Colin Huang <u8813345@xxxxxxxxx>
> >
> > Add devicetree binding documentation for the Delta E50SN12051
> > PMBus-compliant device.
> >
> > Signed-off-by: Colin Huang <u8813345@xxxxxxxxx>
> > ---
> > .../bindings/hwmon/pmbus/delta,e50sn12051.yaml | 42 ++++++++++++++++++++++
> > 1 file changed, 42 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/delta,e50sn12051.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/delta,e50sn12051.yaml
> > new file mode 100644
> > index 000000000000..72aefe212d17
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/hwmon/pmbus/delta,e50sn12051.yaml
> > @@ -0,0 +1,42 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/hwmon/pmbus/delta,e50sn12051.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Delta E50SN12051 PMBus Sensor
> > +
> > +maintainers:
> > + - Kevin Chang <kevin.chang2@xxxxxxx>
> > +
> > +description: |
> > + Delta E50SN12051 is a non-isolated 1/8th brick DC-DC power module.
> > + It is a PMBus-compliant device accessible via an I2C/SMBus interface
> > + and provides standard telemetry such as voltage, current, and
> > + temperature measurements.
> > +
> > +properties:
> > + compatible:
> > + const: delta,e50sn12051
> > +
> > + reg:
> > + maxItems: 1
> > + description: I2C bus address of the PMBus device
> > +
> > +required:
> > + - compatible
> > + - reg
>
> With only these two properties, shouldn't this be in trivial-devices?
Thanks for your comment.
I will remove this file, delta,e50sn12051.yaml,
and add device into trivial-devices.yaml.
>
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + i2c {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + power-module@40 {
> > + compatible = "delta,e50sn12051";
> > + reg = <0x40>;
> > + };
> > + };
> >
> > --
> > 2.34.1
> >
> >