Re: [net-next v3 4/5] net: stmmac: starfive: Add jhb100 SGMII interface

[Minda Chen]

> 
> On Thu, May 07, 2026 at 05:41:14PM +0800, Minda Chen wrote:
> > Add jhb100 compatible and SGMII support. jhb100 soc contains
> > 2 SGMII interfaces and integrated with serdes PHY. SGMII with split
> > TX/RX MAC clock and need to set 2.5M/25M/125M TX/RX clock rate in
> > 10M/100M/1000M speed mode.
> >
> > Signed-off-by: Minda Chen <minda.chen@xxxxxxxxxxxxxxxx>
> > Reviewed-by: Sai Krishna <saikrishnag@xxxxxxxxxxx> @@ -130,6 +160,7 @@
> > static const struct starfive_dwmac_data jh7100_data = {  static const
> > struct of_device_id starfive_dwmac_match[] = {
> >  	{ .compatible = "starfive,jh7100-dwmac", .data = &jh7100_data },
> >  	{ .compatible = "starfive,jh7110-dwmac" },
> > +	{ .compatible = "starfive,jhb100-dwmac" },
> 
> You've declared compatibility with the jh7110, why do you also need to add the
> new comaptible?
> 

I am sorry, I forget to remove this. 

> >  	{ /* sentinel */ }
> >  };
> >  MODULE_DEVICE_TABLE(of, starfive_dwmac_match);
> > --
> > 2.17.1
> >