Re: [PATCH v2 4/4] mailbox: qcom-apcs-ipc: Add Shikra APCS IPC support
From: Dmitry Baryshkov
Date: Fri May 08 2026 - 06:04:39 EST
On Fri, May 08, 2026 at 12:49:50PM +0530, Sneh Mankad wrote:
> From: Vishnu Santhosh <vishnu.santhosh@xxxxxxxxxxxxxxxx>
>
> Enable Shikra APCS IPC support by adding the compatible.
> It reuses apps_shared_apcs_data.
With the DT bindings in place this patch is not required and useless.
>
> Signed-off-by: Vishnu Santhosh <vishnu.santhosh@xxxxxxxxxxxxxxxx>
> Signed-off-by: Sneh Mankad <sneh.mankad@xxxxxxxxxxxxxxxx>
> ---
> drivers/mailbox/qcom-apcs-ipc-mailbox.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mailbox/qcom-apcs-ipc-mailbox.c b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
> index d3a8f6b4a03b368821ef9a5b24fee78037104610..25f76965921ba695e3a1bf4df47ce643916a28cb 100644
> --- a/drivers/mailbox/qcom-apcs-ipc-mailbox.c
> +++ b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
> @@ -168,6 +168,7 @@ static const struct of_device_id qcom_apcs_ipc_of_match[] = {
> { .compatible = "qcom,ipq8074-apcs-apps-global", .data = &ipq6018_apcs_data },
> { .compatible = "qcom,sc7180-apss-shared", .data = &apps_shared_apcs_data },
> { .compatible = "qcom,sc8180x-apss-shared", .data = &apps_shared_apcs_data },
> + { .compatible = "qcom,shikra-apss-shared", .data = &apps_shared_apcs_data },
> { .compatible = "qcom,sm8150-apss-shared", .data = &apps_shared_apcs_data },
> {}
> };
>
> --
> 2.34.1
>
--
With best wishes
Dmitry