Re: [PATCH v4 26/29] soc: qcom: ubwc: drop macrotile_mode from the database

[Dmitry Baryshkov]

On Fri, May 08, 2026 at 12:01:12PM +0200, Konrad Dybcio wrote:
> On 5/7/26 3:03 PM, Dmitry Baryshkov wrote:
> > All the users have been migrated to using qcom_ubwc_macrotile_mode()
> > instead of reading the raw value from the config structure. Drop the
> > field from struct qcom_ubwc_cfg_data and replace it with the calculated
> > value. Split single UBWC_3_0 into UBWC_3_0 (no macrotile mode) and
> > UBWC_3_1 (with macrotile mode).
> > 
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
> > ---
> 
> [...]
> 
> >  static const struct qcom_ubwc_cfg_data sc8180x_data = {
> > @@ -89,7 +84,6 @@ static const struct qcom_ubwc_cfg_data sc8180x_data = {
> >  	.ubwc_swizzle = UBWC_SWIZZLE_ENABLE_LVL2 |
> >  			UBWC_SWIZZLE_ENABLE_LVL3,
> >  	.highest_bank_bit = 16,
> > -	.macrotile_mode = true,
> 
> 8180 should also be 3.1

Indeed.

> 
> with that:
> 
> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
> 
> Konrad

-- 
With best wishes
Dmitry