Re: [RESEND PATCH] s390: fix dead defaults for S390_MODULES_SANITY_TEST and S390_UNWIND_SELFTEST

[Julian Braha]

On 5/8/26 12:22, Alexander Gordeev wrote:
> I could not recreate it. Could you please provide the exact steps?

Sure, here are the exact commands I ran to reproduce for
S390_UNWIND_SELFTEST. Note that I'm on x86-64 and cross-compiling for
s390:

1. Start from a minimal configuration:
'make ARCH=s390 CROSS_COMPILE=s390x-unknown-linux-gnu- allnoconfig'

2. Enter menuconfig:
'make ARCH=s390 CROSS_COMPILE=s390x-unknown-linux-gnu- menuconfig'

3. Set CONFIG_KUNIT=y

4. Set CONFIG_KUNIT_ALL_TESTS=y

5. Check '.config', and see that S390_UNWIND_SELFTEST is still disabled

The steps to reproduce for S390_MODULES_SANITY_TEST are the same, but
you also need to enable MODULES because of the additional dependency.

> I do appreciate your effort to bring a new tool! But unless it is part
> of
> the toolchain it shold not be referred to in a commit message as far as
> I am concerned. IOW, once it is in the tree, it is fine to mention it:

Thanks :)
Separately, I checked with Greg, and he says that:
1. it is a requirement to acknowledge tool usage, but
2. this patch (and others like it) shouldn't have the Fixes tag.

So I will resubmit this patch without "Fixes", but still acknowledging
the tool, see also:
https://lore.kernel.org/all/2026050728-construct-tingle-0852@gregkh/

- Julian Braha