Re: [PATCH net-next 10/12] net: stmmac: tc956x: add TC956x/QPS615 support

[Xilin Wu]

On 5/8/2026 2:44 AM, Alex Elder wrote:
> On 5/6/26 7:59 AM, Xilin Wu wrote:
> > On 5/1/2026 11:54 PM, Alex Elder wrote:
> > > +    /* AXI Configuration */
> > > +    axi = &td->axi;
> > > +    axi->axi_lpi_en = 1;
> > > +    axi->axi_wr_osr_lmt = 31;
> > > +    axi->axi_rd_osr_lmt = 31;
> > > +    /* All sizes (2^2..2^8) are supported */
> > > +    axi->axi_blen_regval = DMA_AXI_BLEN_MASK;
> > > +    plat->axi = axi;
> > > +
> > > +    plat->mac_port_sel_speed = speed;
> > > +    plat->flags = STMMAC_FLAG_MULTI_MSI_EN | STMMAC_FLAG_TSO_EN;
> >
> > I got WoL working only after adding STMMAC_FLAG_USE_PHY_WOL here. I 
> > guess it's required, since the driver clocks down the MAC/PMA/XPCS in 
> > its suspend hook?
>
> I just want to respond to this with a summary of our plans.
>
> We will *not* be implementing wake-on-LAN (WoL) initially.  We
> will work to get support for the eMACs upstream for TC956x, and
> then as a separate step, we will enable WoL.
>
> It's great to know you have it working, and our plan is to
> implement it via the PHYs and not involve the MAC.  It seems
> it will be relatively easy, but we have no plans to add it to
> the current series.
>
>                      -Alex

Hi Alex,

Maybe I missed something, but I already have WoL working *without* 
changes in the tc956x driver.

https://lore.kernel.org/all/859776B5671B36B9+577c19e4-3e66-4036-b26f-fe20287a1d43@xxxxxxxxx/


--
Best regards,
Xilin Wu <sophon@xxxxxxxxx>