Re: [PATCH net-next 10/12] net: stmmac: tc956x: add TC956x/QPS615 support

[Andrew Lunn]

> BTW if you are bothered by SP_SEL_SGMII_2500M, that name comes directly
> from the TRM and I'd prefer to keep it if I can. The enumerated value
> we have to write into the SP_SEL for 2500base-X is "SGMII 2500M".

We try to avoid anything to do with SGMII and 2500 because it is
technically wrong. Cisco never defined SGMII for 2500, it is something
silicon vendors have made up, without any foundation in any
standardisation. We much prefer to refer to it as 2500BaseX with
broken signalling, which is a much more accurate description.

The TRM is also not a public document. If it was, i could see some
value in keeping with the naming, but since ~0 developers have the
document, this is less useful.

	Andrew