Re: [PATCH v2 1/2] i2c: tegra: fix pm_runtime leak on mutex_lock failure

[Jon Hunter]

On 08/05/2026 11:24, Thierry Reding wrote:
> On Thu, May 07, 2026 at 10:11:44PM +0000, Saurav Sachidanand wrote:
> > If tegra_i2c_mutex_lock() fails, the function returns without calling
> > pm_runtime_put(), leaking the runtime PM reference acquired by the
> > preceding pm_runtime_get_sync(). This prevents the device from ever
> > entering runtime suspend.
> >
> > Add the missing pm_runtime_put() before returning on lock failure.
> >
> > Fixes: 6077cfd716fb ("i2c: tegra: Add support for SW mutex register")
> > Signed-off-by: Saurav Sachidanand <sauravsc@xxxxxxxxxx>
> > ---
> >   drivers/i2c/busses/i2c-tegra.c | 4 +++-
> >   1 file changed, 3 insertions(+), 1 deletion(-)
>
> Acked-by: Thierry Reding <treding@xxxxxxxxxx>


Reviewed-by: Jon Hunter <jonathanh@xxxxxxxxxx>

Thanks
Jon

--
nvpublic