Re: [PATCH 0/3] hwmon: lm93: clean up coding style issues

[Guenter Roeck]

On 5/7/26 03:11, Ninad Naik wrote:
> This patch series includes code style changes for lm93 driver to fix
> several checkpatch.pl warnings. No functional changes are made. I tested
> the changes by compiling the file.
>
> Changes include:
> - Add blank lines after variable declarations
> - Change 'unsigned' to 'unsigned int'
> - Remove else blocks after break or return statements
>
> Ninad Naik (3):
>    hwmon: lm93: Add missing blank lines after declarations
>    hwmon: lm93: Change unsigned to unsigned int for clarity
>    hwmon: lm93: Remove else blocks after break or return for consistency
>
>   drivers/hwmon/lm93.c | 87 ++++++++++++++++++++++++++++----------------
>   1 file changed, 56 insertions(+), 31 deletions(-)

Please refrain from submitting such cleanups into the hwnon subsystem.
As you can see from Sashiko's feedback, the driver has functional problems.
On top of that, it uses a deprecated API.

Fixing actual bugs and backporting them is only made more difficult by
cosmetic changes. I don't mind if cosmetic changes are made as part of
a functional series, in this case for example when porting the driver
to use the with_info hwmon API. On their own they have no value.

Thanks,
Guenter