Re: [PATCH 2/3] ntfs: fix MFT bitmap scan 2^32 boundary check

[Namjae Jeon]

> Fixes: d3ad708fecaa ("ntfs: Initial commit")
The warning from checkpatch.pl indicates that the commit ID you
provided in the Fixes: tag does not exist...

WARNING: Unknown commit id 'd3ad708fecaa', maybe rebased or not pulled?
#67:
Fixes: d3ad708fecaa ("ntfs: Initial commit")

If the Fixes: tag refers to a commit from an oot version, please do
either remove the tag or replace it with the correct upstream commit
ID that introduced the bug. Other patches also have this tag, so
please update them all.

> @@ -1279,7 +1279,7 @@ static s64 ntfs_mft_bitmap_find_and_alloc_free_rec_nolock(struct ntfs_volume *vo
>                                 b = ffz((unsigned long)*byte);
>                                 if (b < 8 && b >= (bit & 7)) {
>                                         ll = data_pos + (bit & ~7ull) + b;
> -                                       if (unlikely(ll > (1ll << 32))) {
> +                                       if (unlikely(ll >= (1ll << 32))) {
>  #if LINUX_VERSION_CODE >= KERNEL_VERSION(6, 6, 0)
The kernel version check code is not in the mainline, so it seems this
patch was created in the oot version... I cannot apply it unless you
remove this.
>                                                 folio_unlock(folio);
>                                                 kunmap_local(buf);
> --
> 2.34.1
>