Re: [RFC PATCH] scsi: scsi_transport_srp: Move long delayed work on system_dfl_long_wq
From: Marco Crivellari
Date: Sat May 09 2026 - 09:30:55 EST
On Fri, May 8, 2026 at 6:11 PM Bart Van Assche <bvanassche@xxxxxxx> wrote:
> [...]
> This looks like unnecessary churn to me. The motivation for the
> introduction of system_dfl_long_wq seems very weak to me. Wouldn't we
> all be better off if commit c116737e972e would be reverted and if the
> behavior of system_long_wq would be modified from per-CPU into unbound?
Hello Bart,
There are not many users of `queue_delayed_work(system_long_wq,...)`, anyhow
there are API guarantees, so we cannot just change the workqueue used there,
in my opinion.
Also, consider that system_long_wq is used by more than just
queue_delayed_work().
Approximately, 60 queue_work() users specify system_long_wq, some of them
may really need to be per-cpu.
Thanks.
--
Marco Crivellari
SUSE Labs