Re: [PATCH v2] staging: iio: addac: adt7316: check SPI write errors in probe
From: Maxwell Doose
Date: Sat May 09 2026 - 22:13:06 EST
On Sat, May 9, 2026 at 9:00 PM Denny Lin <dennylin0707@xxxxxxxxx> wrote:
>
> Hi Nuno, Maxwell,
>
> Thanks for the feedback.
>
> I agree that just warning is not very useful, and we should bail out on
> errors if we check them. However, I currently cannot test the failure
> case and I'm not sure how the device behaves if the switching sequence
> is interrupted.
>
> I've reached out to Analog Devices to clarify this. For now, I think it's
> safer not to change the behavior until we have confirmation.
>
> I'll follow up once I have more information.
>
> Thanks,
> Hungyu
>
Two things. One, please don't top-post, and two, from what I've heard
the switching sequence tends to be very error-prone since (I think)
we're essentially spamming the bus with spi data while we're still in
i2c mode, so we may want to ignore error codes anyways. Just a
heads-up.
best regards,
max