Re: [PATCH v2] staging: iio: addac: adt7316: check SPI write errors in probe

[Maxwell Doose]

On Sun, May 10, 2026 at 1:23 AM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxx> wrote:
> On Sat, May 09, 2026 at 09:03:20AM +0000, Hungyu Lin wrote:
[snip]
>
> There was an attempt in the past to do the same and it was NAKed, so is this now.
> NAK.
>
> Instead, add a better comment, if you wish, with the citing from the datasheet
> to explain the magic here and why we don't check for the error codes.
>

Agree with Andy here on the comment, I'm personally not a fan of how
undocumented this "spam data on the bus and see if it works" stuff is.
Make sure to mention:

1. We're in the transitional state between I2C and SPI
2. Facts from the data sheet about why this is what we're doing
3. Why we shouldn't check the return values from the spi_write() calls

best regards,
max




> --
> With Best Regards,
> Andy Shevchenko
>
>
>