Re: [PATCH v2 2/2] iio: magnetometer: add driver for MEMSIC MMC5983MA

[Andy Shevchenko]

On Sat, May 09, 2026 at 05:09:33PM -0500, David Lechner wrote:
> On 5/7/26 3:50 PM, Vladislav Kulikov wrote:
> > Add support for the MEMSIC MMC5983MA 3-axis magnetometer. The driver
> > provides raw magnetic field readings via IIO sysfs with SET/RESET
> > offset cancellation for each measurement.

...

> > +	ret = regmap_read_poll_timeout(data->regmap, MMC5983_REG_STATUS,
> > +				       status,
> > +				       status & MMC5983_STATUS_MEAS_M_DONE_BIT,
> > +				       10000, 50000);
> 
> I wouldn't mind seeing 10 * KILO, 50 * KILO here to make it easier to read.

No, it should be USEC_PER_MSEC (requires time.h to be included).

> > +	if (ret)
> > +		return ret;

-- 
With Best Regards,
Andy Shevchenko