Re: [PATCH 3/3] iio: chemical: scd30: make command lookup table const
From: Maxwell Doose
Date: Sun May 10 2026 - 03:52:30 EST
On Sun, May 10, 2026 at 2:47 AM Stepan Ionichev <sozdayvek@xxxxxxxxx> wrote:
>
> On Sun, 10 May 2026, Andy Shevchenko wrote:
> > > scd30_i2c_cmd_lookup_tbl[] holds the fixed CMD_* opcodes and is only
> > > ever read in scd30_i2c_command() (via put_unaligned_be16 of the looked
> > > up entry). Marking it const matches how it is used and lets the table
> > > land in .rodata.
> >
> > I believe the above is the suggestion on the correction of the commit message?
> > Please, make it clear!
>
> Sorry for the ambiguity -- that paragraph was just my own reasoning
> for the Reviewed-by tag (i.e. what I checked and why I think the
> change is correct), not a proposed rewording of the commit message.
> Giorgi's commit message already reads fine; no changes requested
> from me.
>
I'm curious, are you having AI do your reviews?
best regards,
max